feat: add per-side weight input for volume calculations#7
Merged
Conversation
Add warden.toml with code-simplifier (getsentry/skills) and find-bugs (getsentry/warden) triggers. Update validate skill to run warden -v after tests pass. Address warden findings: extract shared exercise parsing helper and add schema validation in updateTemplate.
Dumbbell exercises now correctly report total weight moved by applying a 2x multiplier in volume calculations. PRs and E1RM remain based on input weight. Adds weightInput field to Exercise schema, tags 6 dumbbell exercises as per-side, and updates CLI commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
weightInputfield (total|per-side) to Exercise schema so volume calculations correctly double weight for dumbbell exercises (e.g., 50lb curls = 100lb total moved)per-side; all others default tototal--weight-inputinexercises addandexercises editcommands, shows value inexercises shownpx @sentry/wardenand clarifies it only needs to run once before PR creationTest Plan
weightInputtags🤖 Generated with Claude Code